[vlc-devel] [PATCH 1/2] decoder: Give packetizer aspect ratio to decoder.

[Julian Scheel]

Am 06.09.2013 12:08, schrieb Rémi Denis-Courmont:
> On Fri,  6 Sep 2013 11:28:28 +0200, Julian Scheel <julian at jusst.de> wrote:
>> When the packetizer detects a valid pixel aspect ratio this should be
>> forwarded to the decoders input format. This is helpful for decoder
> modules
>> which do not detect the aspect ratio on their own.
>>
>> Signed-off-by: Julian Scheel <julian at jusst.de>
>> ---
>>   src/input/decoder.c | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/src/input/decoder.c b/src/input/decoder.c
>> index 9221426..d9283e3 100644
>> --- a/src/input/decoder.c
>> +++ b/src/input/decoder.c
>> @@ -1823,6 +1823,18 @@ static void DecoderProcessVideo( decoder_t
> *p_dec,
>> block_t *p_block, bool b_flus
>>                   es_format_Clean( &p_dec->fmt_in );
>>                   es_format_Copy( &p_dec->fmt_in, &p_packetizer->fmt_out
> );
>
> This is copying the format already. The patch makes no sense to me.

It copies the format only when extradata is passed by the packetizer - 
and one time at startup, but not when it changes later on. I think the 
aspect information should be passed no matter if extradata comes from 
the packetizer or not.

-Julian