[vlc-devel] [PATCH] opus: add opus encoder
Timothy B. Terriberry
tterribe at xiph.org
Tue Sep 17 13:02:56 CEST 2013
I haven't reviewed the whole patch, but a couple of comments:
Denis Charmet wrote:
> You are assuming little endian running host what about a big endian?
> (yes it is rare but still).
These are for reading/writing values from the headers, no? Those fields
are defined to be little-endian (c.f.
>> + const char *opus_version = opus_get_version_string();
> Is that an allocated string? if yes don't you need a free?
No, it's a static constant.
More information about the vlc-devel