[vlc-devel] [PATCH] opus: add opus encoder

[Tristan Matthews]

Hi,

> +        // add padding to beginning
> > +        if (sys->padding) {
> > +            const size_t leftover_space = OPUS_FRAME_SIZE -
> sys->i_nb_samples;
> > +            padding_start = fill_buffer(enc, padding_start,
> sys->padding,
> > +                    __MIN(sys->padding->i_nb_samples, leftover_space));
> > +            if (sys->padding->i_nb_samples <= 0) {
> > +                block_Release(sys->padding);
> > +                sys->padding = 0;
> > +            }
> > +        }
> > +
> > +        if (!sys->padding) {
> use else
>


Since sys->padding may have changed to 0 in the previous if block, the two
branches aren't mutually exclusive. That said, I will put a comment in to
make that clearer.

Thanks for getting back to me so quickly, I will resend a patch once with
all of those changes once I've updated the patch to use newer opus API.

Best,
Tristan

-- 
Tristan Matthews
web: http://tristanswork.blogspot.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130917/a8a3f162/attachment.html>