[vlc-devel] [PATCH] demux: ogg: add skeleton index seeking

[Jean-Baptiste Kempf]

On 18 Sep, Francois Cartegnie wrote :
> +    else if( !strncmp(psz_value, "application/kate", 16) )
> +    {
> +        /* ??? */
> +        p_stream->fmt.i_cat = UNKNOWN_ES;
> +        free( p_stream->fmt.psz_description );
> +        p_stream->fmt.psz_description = strdup("OGG Kate Overlay (Unsupported)");
> +    }

SPU_ES.

> @@ -44,6 +45,7 @@ typedef struct logical_stream_s
>       * them to the decoder. */
>      bool             b_force_backup;
>      int              i_packets_backup;
> +    bool             b_have_updated_format;
>      void             *p_headers;
>      int              i_headers;
>      ogg_int64_t      i_previous_granulepos;

Please avoid bool/int/bool/void pattern


I think that you are closing a few Ogg bugs, you should mention them.

Moreover, are you not breaking OGM support?

Best regards,


-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device