[vlc-devel] [PATCH] demux: ogg: add skeleton index seeking

[Francois Cartegnie]

Le 18/09/2013 19:37, Denis Charmet a écrit :

>>          case DEMUX_SET_TIME:
>> +            i64 = (int64_t)va_arg( args, int64_t );
>> +            if ( Ogg_SeekUsingSkeletonIndex( p_demux, i64 ) )
>> +                return VLC_SUCCESS;
>>              return VLC_EGENERIC;
> 
> It cannot apply to DEMUX_SET_POSITION?
>>  

Well it seems weird (landing too early).
Seems patching DEMUX_GET_POSITION first is mandatory.

>> +        ! memcmp ( p_oggpacket->packet, "fisbone\0", 8 ) )
> Aren't you missing an 'h'? btw "" already appends a '\0'.

No, and Yes.

>> +static void Ogg_ApplyContentType( logical_stream_t *p_stream, const char* psz_value,
>> +                                  bool *b_force_backup, bool *b_packet_out )
>> +{
> Is it normal that there is no default value for b_force_backup or
> b_packet_out?

Write only vars for factorization. Unused by one of the caller.

>> +    }
> no else for unknown value so far?
>> +}

Else we do nothing.

Francois