[vlc-devel] [PATCH] access: dvb: Realloc block to actually used size.

[Denis Charmet]

Hi,

Le vendredi 20 septembre 2013 à 11:48:48, Julian Scheel a écrit :
> For low bandwidth streams (seen with DVB-C Radio) it can happen that the blocks
> are not fully used, because less than 20 TS packets are available from the
> demuxer at the given time. This leads to a quite high memory usage due to empty
> buffer memory lying around. Avoid this by reallocating the buffer blocks to the
> actually used size, like it is done in other access modules (ie udp) already.
> 

I find this highly debatable, it's the usual memory vs perf controversy,
realloc'ing every packet to handle low bw streams seems quite a lot of
CPU waste.
I'd rather see a basic use of smaller buffer or an adaptation
of the BUFSIZE using previous val values.

Regards,

-- 
Denis Charmet - TypX
Le mauvais esprit est un art de vivre