[vlc-devel] [PATCH] audio_filter: SOFAlizer new module

[Jean-Baptiste Kempf]

On 23 Sep, Andreas Fuchs wrote :
>  AC_CHECK_LIB(m,cos,[
> -  VLC_ADD_LIBS([adjust wave ripple psychedelic gradient a52tofloat32 dtstofloat32 x264 goom noise grain scene chorus_flanger freetype swscale postproc equalizer spatializer param_eq samplerate freetype mpc qt4 compressor headphone_channel_mixer normvol audiobargraph_a audiobargraph_v mono colorthres extract ball hotkeys mosaic gaussianblur x262 x26410b hqdn3d anaglyph oldrc ncurses oldmovie glspectrum],[-lm])
> +  VLC_ADD_LIBS([adjust wave ripple psychedelic gradient a52tofloat32 dtstofloat32 x264 goom noise grain scene chorus_flanger freetype swscale postproc equalizer spatializer param_eq samplerate freetype mpc qt4 compressor headphone_channel_mixer normvol audiobargraph_a audiobargraph_v mono colorthres extract ball hotkeys mosaic gaussianblur x262 x26410b hqdn3d anaglyph oldrc ncurses oldmovie glspectrum sofalizer],[-lm])
>    LIBM="-lm"


> +dnl 
> +dnl  NetCDF library for SOFAlizer Plugin 
> +dnl 
> +AS_IF([test "${SYS}" = "linux"], [ 
> +AC_ARG_ENABLE(sofalizer, 
> +  [  --enable-sofalizer            netcdf-binarual support (default enabled)]) 
> +if test "${enable_sofalizer}" != "no" 
> +then 
> +   PKG_CHECK_MODULES(NETCDF,netcdf, 
> +   [ 
> +      AC_CHECK_HEADERS(netcdf.h, [], [AC_MSG_ERROR([Missing header file netcdf.h.])] ) 
> +      VLC_ADD_PLUGIN([sofalizer]) 
> +      VLC_ADD_LDFLAGS([sofalizer],[$NETCDF_LIBS]) 
> +      VLC_ADD_CFLAGS([sofalizer], [$NETCDF_CFLAGS]) 
> +])
> +fi 
> +])
> +
> +AS_IF([test "${SYS}" = "mingw32"], [ 
> +AC_ARG_ENABLE(sofalizer,
> +  [  --enable-sofalizer            netcdf-sofalizer support (default enabled)])
> +if test "${enable_sofalizer}" != "no"
> +then
> +VLC_ADD_PLUGIN([sofalizer])
> +VLC_ADD_LIBS( [sofalizer], [ -lnetcdf])
> +AC_CHECK_HEADERS(netcdf.h, [], [AC_MSG_ERROR([Missing header file netcdf.h.])] )
> +AC_ARG_WITH([netcdf-include-path],
> +     [AS_HELP_STRING([--with-netcdf-include-path],
> +        [location of the NetCDF headers, default to /usr/include/])],
> +     [NETCDF_CFLAGS='-I${CONTRIB_DIR}/include'])
> +AC_SUBST([NETCDF_CFLAGS])
> +
> +AC_ARG_WITH([netcdf-lib-path], 
> +    [AS_HELP_STRING([--with-netcdf-lib-path], [location of the netCDF libraries])],
> +    [NETCDF_LIBS='-lnetcdf'])
> +AC_SUBST([NETCDF_LIBS])
> +
> +VLC_ADD_LDFLAGS([sofalizer],[$NETCDF_LIBS])
> +VLC_ADD_CFLAGS([sofalizer], [$NETCDF_CFLAGS])

No. Please use just the PKG check, in one line, for all the
architectures.

> +fi
> +])
> +
> +dnl
> +dnl Libnotify notification plugin
> +dnl
> +PKG_ENABLE_MODULES_VLC([NOTIFY], [], [libnotify gtk+-2.0], [libnotify notification], [auto])
> +

This shoud not be in the patch.

> diff --git a/extras/package/win32/package.mak b/extras/package/win32/package.mak
> index b523646..9477b99 100644
> --- a/extras/package/win32/package.mak
> +++ b/extras/package/win32/package.mak
> @@ -43,6 +43,18 @@ package-win-common: package-win-install build-npapi
>  	cp $(srcdir)/share/icons/vlc.ico $(win32_destdir)
>  	cp -r $(prefix)/lib/vlc/plugins $(win32_destdir)
>  	-cp -r $(prefix)/share/locale $(win32_destdir)
> +	
> +if HAVE_WIN32
> +	cp $(srcdir)/contrib/i686-w64-mingw32/bin/netcdf.dll $(win32_destdir)
> +	cp $(srcdir)/contrib/i686-w64-mingw32/bin/msvcp100.dll $(win32_destdir)
> +	cp $(srcdir)/contrib/i686-w64-mingw32/bin/msvcr100.dll $(win32_destdir)
> +	cp $(srcdir)/contrib/i686-w64-mingw32/deps/shared/bin/hdf5.dll $(win32_destdir)
> +	cp $(srcdir)/contrib/i686-w64-mingw32/deps/shared/bin/hdf5_hl.dll $(win32_destdir)
> +	cp $(srcdir)/contrib/i686-w64-mingw32/deps/shared/bin/libcurl.dll $(win32_destdir)
> +	cp $(srcdir)/contrib/i686-w64-mingw32/deps/shared/bin/szip.dll $(win32_destdir)
> +	cp $(srcdir)/contrib/i686-w64-mingw32/deps/shared/bin/zlib.dll $(win32_destdir)
> +	cp $(srcdir)/contrib/i686-w64-mingw32/deps/shared/bin/zlib1.dll $(win32_destdir)
> +endif	

This is very very wrong, so no.

> + * Licensed under the EUPL, Version 1.1 or – as soon they will be approved by
> + * the European Commission - subsequent versions of the EUPL (the "Licence");
> + * You may not use this work except in compliance with the Licence. You may
> + * obtain a copy of the Licence at: http://ec.europa.eu/idabc/eupl

No. Why???

> +#define FILE1_NAME_TEXT N_( "SOFA file 1" )
> +#define FILE2_NAME_TEXT N_( "SOFA file 2" )
> +#define FILE3_NAME_TEXT N_( "SOFA file 3" )
> +#define FILE4_NAME_TEXT N_( "SOFA file 4" )
> +#define FILE5_NAME_TEXT N_( "SOFA file 5" )

What is the use of 5 files?

> diff --git a/modules/gui/qt4/components/extended_panels.cpp b/modules/gui/qt4/components/extended_panels.cpp

Nothing to do in this patch. UI is UI...

Best regards,


-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device