[vlc-devel] [PATCH] Option to ignore PCR jitter

[David R Robison]

Looking at the code, if I have my clock-jitter set so that it will not 
force an increase in the buffer, is there any reason to re-buffer and/or 
reset the PCR? This would be the case for the following conditional in 
es-out.c:

if( i_pts_delay > __MIN( i_pts_delay_base + i_jitter_max, 
INPUT_PTS_DELAY_MAX ) )
{
       msg_Err( p_sys->p_input,
               "ES_OUT_SET_(GROUP_)PCR  is called too late (jitter of %d 
ms ignored)",
       (int)(i_pts_delay - i_pts_delay_base) / 1000 );
        i_pts_delay = p_sys->i_pts_delay;
}

David

David R Robison
Open Roads Consulting, Inc.
103 Watson Road, Chesapeake, VA 23320
phone: (757) 546-3401
e-mail: drrobison at openroadsconsulting.com
web: http://openroadsconsulting.com
blog: http://therobe.blogspot.com
book: http://www.xulonpress.com/bookstore/bookdetail.php?PB_ISBN=9781597816526

On 9/18/2013 10:17 AM, David R Robison wrote:
> Yes that is part of the problem, but I don't want the buffer to grow 
> either. I guess if the clock-jitter was set to 0 (zero) then it seems 
> from the code that it should only need to resync the PCR clocks but 
> not increase the buffer which should not require a buffer flush, 
> however, I think the PCR reset is what is also clearing and re-filling 
> the buffer. Maybe there is another way around this without clearing 
> the buffer... David
>
> David R Robison
> Open Roads Consulting, Inc.
> 103 Watson Road, Chesapeake, VA 23320
> phone: (757) 546-3401
> e-mail: drrobison at openroadsconsulting.com
> web: http://openroadsconsulting.com
> blog: http://therobe.blogspot.com
> book: 
> http://www.xulonpress.com/bookstore/bookdetail.php?PB_ISBN=9781597816526
>
> On 9/18/2013 9:48 AM, Rafaël Carré wrote:
>> Thanks for the details,
>>
>> I was looking at this comment in the code:
>> /* It is not really good, as we throw away already buffered data
>>   * TODO have a mean to correctly reenter bufferization */
>>
>> Perhaps the bug is throwing away the already buffered data.
>



This email communication (including any attachments) may contain confidential and/or privileged material intended solely for the individual or entity to which it is addressed.
If you are not the intended recipient, please delete this email immediately.