[vlc-devel] [PATCH] Reshuffle after playthrough

Alex Warhawk ax.warhawk at gmail.com
Mon Sep 30 22:34:10 CEST 2013


i spent some time testing the changes and it seems like my assumption was
wrong. the player does not always start with element 0 when a loop is
completed.

when you hit the next button on the player the action is handled via the
request mechanism - because of this shuffling the playlist won't assure all
titles are played before the next shuffle occurs because it does not start
with element 0.

i created a "better" patch which fixes the shuffle issue if you let vlc
play without hitting the next button. it will play all elements in the
playlist once, than shuffle the list and play ever element once again in a
different order before shuffling the list again ....

hitting the next button will result in the same behavior we currently have.

i attach the diff to this message, please have a look and tell me whether i
should create another thread on the mailing list?


On Mon, Sep 30, 2013 at 12:37 PM, Jean-Baptiste Kempf <jb at videolan.org>wrote:

> On 30 Sep, Alex Warhawk wrote :
> > i think so, ResetCurrentlyPlaying shuffles the whole playlist array. the
> > lines i added are only executed when the current element is the last
> > element in this playlist. it therefore shuffles again and starts playing
> at
> > element 0 if loop is activated.
>
> It would be nice if someone could test.
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130930/5ae040f1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: application/octet-stream
Size: 747 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130930/5ae040f1/attachment.obj>


More information about the vlc-devel mailing list