[vlc-devel] [PATCH] avcodec: Fix memory leak in EncodeVideo

[Tristan Matthews]

On Mon, Apr 7, 2014 at 11:01 AM, Brian Schmidt <brian.schmidt at weather.com>wrote:

> ---
>  modules/codec/avcodec/encoder.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/modules/codec/avcodec/encoder.c
> b/modules/codec/avcodec/encoder.c
> index 9bfe238..d6f3a80 100644
> --- a/modules/codec/avcodec/encoder.c
> +++ b/modules/codec/avcodec/encoder.c
> @@ -1090,6 +1090,7 @@ static block_t *EncodeVideo( encoder_t *p_enc,
> picture_t *p_pict )
>              {
>                  msg_Warn( p_enc, "almost fed libavcodec with two frames
> with "
>                            "the same PTS (%"PRId64 ")", frame->pts );
> +                block_Release( p_block );
>                  return NULL;
>              }
>              else if ( p_sys->i_last_pts > frame->pts )
> @@ -1097,6 +1098,7 @@ static block_t *EncodeVideo( encoder_t *p_enc,
> picture_t *p_pict )
>                  msg_Warn( p_enc, "almost fed libavcodec with a frame in
> the "
>                           "past (current: %"PRId64 ", last: %"PRId64")",
>                           frame->pts, p_sys->i_last_pts );
> +                block_Release( p_block );
>                  return NULL;
>              }
>              else
>

Good catch, it's now merged.

Best,
Tristan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140407/b27bbd7c/attachment.html>