[vlc-devel] [PATCH 3/3] codec/mmal: Add MMAL-based decoder plugin

[Jean-Baptiste Kempf]

On 04 Apr, Julian Scheel wrote :
> +static int OpenDecoder(decoder_t *dec)
> +{
> +    int ret = VLC_SUCCESS;
> +    decoder_sys_t *sys;
> +    MMAL_PARAMETER_BOOLEAN_T error_concealment;
> +    MMAL_PARAMETER_UINT32_T extra_buffers;
> +    MMAL_STATUS_T status;
> +
> +    if (dec->fmt_in.i_cat != VIDEO_ES) {
> +        ret = VLC_EGENERIC;
> +        goto out;
> +    }
> +
> +    if (dec->fmt_in.i_codec != VLC_CODEC_MPGV && dec->fmt_in.i_codec != VLC_CODEC_H264) {
> +        ret = VLC_EGENERIC;
> +        goto out;
> +    }

On those 2 cases, you should just return directly.
The out label is just calling CloseDecoder that does not do anything if
sys is not allocated yet.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device