[vlc-devel] [PATCH] Change tooltip message to Position: @current time

[David Fuhrmann]

Hello Sophia,

Am 02.04.2014 um 17:47 schrieb Sophia Ngo <sophia.ngo at sjsu.edu>:

> ---
> .../tmp/build/vlc.build/Default/vlc.build/vlc.dep  | 120 ++++++++++-----------
> build/tmp/modules/gui/macosx/ControlsBar.m         |   4 +

It looks like you misconfigured your git checkout. I assume that you have the vlc source code in a vlc folder, and that you created a build subfolder for storing the compilation files. This build folder include the vlc.dep file which is just a result of the build process and is not needed in your patch. Additionally, the build folder also includes copies of some source files, like ControlsBar.m in this case. But these are not the actual files you should work with. Instead, you need to edit the files in vlc/modules/gui/macosx/*.
A "git diff“ should show file paths like "--- a/modules/gui/macosx/…“ for a correct patch.

>         o_time = [[VLCStringUtility sharedInstance] getCurrentTimeAsString: p_input negative:[o_time_fld timeRemaining]];

This might get the time as a remaining time, if the time field is set up this way. For the tooltip, the current time will fit better IMO.
(Ideally, it might not only show the current time, but the time for the position where the cursor is on the time slider.)

> 
> +        // tooltip message display "Position: current time"
> +        NSString *currentTimeOnToolTip = @"Position: „;

This string needs to be marked as translatable (see the _NS macro for that). And it should also include the position of the time in the string, like "Position: %@". This way, the translator can decide to put the time at another location within the string.

With best regards,
David