[vlc-devel] [PATCH/RFC] Add hotkey to rotate video.

[Matthias Keiser]

Am 01.04.2014 um 20:02 schrieb Rémi Denis-Courmont <remi at remlab.net>:

> On Tue,  1 Apr 2014 10:40:25 +0200, Matthias Keiser
> <matthias at tristan-inc.com> wrote:
>> I'm not sure this is the right way to do this, however this:
>> - works with all video output modules
> 
> Actually, this won't at all with hardware passthrough, while it will yield
> an ugly inverted aspect ratio otherwise.

Yes it seems adding a transpose filter to the "normal" filter chain is broken atm. I checked this thread: https://trac.videolan.org/vlc/ticket/10745 but it didn't get clear to me how you propose we fix this. We can't do it the way we established it with the other rotation patches without destroying and recreating the vout module each time we rotate, right?
> 
>> - can be applied on the fly
> 
> But it will not cooperate with the GUI setting, I guess. This will confuse
> users.

Actually I thought this was a feature, not a bug.

> Also four keys is just too much for a hotkey IMHO.

At last, a problem I feel confident to fix!

> -- 
> Rémi Denis-Courmont
> Sent from my collocated server
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel