[vlc-devel] [PATCH] ugly resampler, handle that output data isn't longer than input data

Ilkka Ollakka ileoo at videolan.org
Mon Apr 21 19:49:24 CEST 2014


On Mon, Apr 21, 2014 at 12:46:26PM +0300, Rémi Denis-Courmont wrote:
> Le dimanche 20 avril 2014, 12:24:49 ileoo at videolan.org a écrit :
> > +    msg_Info( p_filter, "input samples %d length %d",
> > p_in_buf->i_nb_samples, p_in_buf->i_length );

> Too verbose. Also, wrong format string.

Thanks for checking.


> I think this is pretty much as wrong as the previous code. We should account 
> for rounding errors, e.g. using date_*(). This would require a special case 
> for discontinuities though.

Yes, I think you are right. With same effort code could use date_*() and
take account rounding errors.

-- 
Ilkka Ollakka
I just got my PRINCE bumper sticker ... But now I can't remember WHO he is ...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140421/7dc3d42d/attachment.sig>


More information about the vlc-devel mailing list