[vlc-devel] [PATCH 02/10] MED Support - Core controls and definitons

Roiy Shpaner roiy at cs.umanitoba.ca
Tue Apr 29 18:49:24 CEST 2014


I wasn't asking for a rephrasing, but for a simple pointing at the line(s) you found to be incorrect. I don't think that's unusual, almost all reviews here have a review comment along with the related few lines. This is especially important when the file we are talking about has 715 lines changed..

It may be obvious, and I may be a bad programmer or what not, but I can't read your mind, and I don't see the value in holding that information back. 
If I knew what the problem was it wouldn't have been there in the first place.
What is there to gain from not being specific here? A punishment? Aren't we all working for the same goal?

Similarly, when you say realloc is still leaking, can you please state in what case? Last time I had to guess you were referring to a failure to allocate memory state. So either my guess of reading your mind was wrong, or there's another case.


> -----Original Message-----
> From: vlc-devel [mailto:vlc-devel-bounces at videolan.org] On Behalf Of Rémi
> Denis-Courmont
> Sent: April-28-14 4:05 PM
> To: vlc-devel at videolan.org
> Subject: Re: [vlc-devel] [PATCH 02/10] MED Support - Core controls and
> definitons
> Le jeudi 24 avril 2014, 15:31:07 Roiy Shpaner a écrit :
> > Hey Rémi,
> >
> > Thanks for taking another look at it.
> > I looked over your previous emails and couldn't find any race issues,
> > I also went over the input controls again, and couldn't see anything
> > pop out or any missing locks.
> I can't put it another way. It's obvious where the input state is accessed with
> serialization. Also, still the same realloc leaks.
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list