[vlc-devel] [vlc-commits] avcodec: missing initializer (cid #1191736)

[Rémi Denis-Courmont]

Le lundi 4 août 2014, 23:14:30 Tristan Matthews a écrit :
> vlc | branch: master | Tristan Matthews <le.businessman at gmail.com> | Mon Aug
>  4 17:00:57 2014 -0400| [2da697261ff55dfe4f654ce9a591c3b4d5f98815] |
> committer: Tristan Matthews
> 
> avcodec: missing initializer (cid #1191736)

> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2da697261ff55dfe4f6
> > 54ce9a591c3b4d5f98815
> ---
> 
>  modules/codec/avcodec/encoder.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/codec/avcodec/encoder.c
> b/modules/codec/avcodec/encoder.c index 0c4f2e4..8f2b898 100644
> --- a/modules/codec/avcodec/encoder.c
> +++ b/modules/codec/avcodec/encoder.c
> @@ -709,7 +709,7 @@ int OpenEncoder( vlc_object_t *p_this )
>           * Copied from audio.c
>           */
>          const unsigned i_order_max = 8 * sizeof(p_context->channel_layout);
> -        uint32_t pi_order_dst[AOUT_CHAN_MAX];
> +        uint32_t pi_order_dst[AOUT_CHAN_MAX] = { };

Do you care to explain how this fixes anything? I don't see how any error case 
is handled any better than before.

-- 
Rémi Denis-Courmont
http://www.remlab.net/