[vlc-devel] [PATCH] configure: do not escape double quation mark

[Rafaël Carré]

Hi,

On 08/08/14 08:11, KO Myung-Hun wrote:
> 
> Hi/2.
> 
> Fixed a typo.
> 
> KO Myung-Hun wrote:
>> This fixes the following error.
>>
>> -----
>> sed: -e expression #1, char 1: unknown command: `"'
>> -----
>> ---
>>  configure.ac |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index de07e28..ddf4770 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -4274,7 +4274,7 @@ echo "#! $SHELL
>>  rm -f .error\$\$
>>  ERROR=0
>>  export PATH=\"$PATH\" LANG=C
>> -($MAKE V=1 \$@ 2>&1 || touch .error\$\$)| `sed -ne \"s/^top_srcdir *= *//p\" < Makefile`/extras/buildsystem/make.pl
>> +($MAKE V=1 \$@ 2>&1 || touch .error\$\$)| `sed -ne "s/^top_srcdir *= *//p" < Makefile`/extras/buildsystem/make.pl
>>  test -f .error\$\$ && ERROR=1
>>  rm -f .error\$\$
>>  exit \$ERROR" >compile

This is a revert of:

http://git.videolan.org/?p=vlc.git;a=commitdiff;h=96f3458656bbb207ffe0d15678ca96ae38c8f5d9;hp=3414682cbdc046cfe0be16df0abbed5a87ac1fbc

And I think escaping is needed:

echo "#! $SHELL
rm -f .error\$\$
ERROR=0
export PATH=\"$PATH\" LANG=C
($MAKE V=1 \$@ 2>&1 || touch .error\$\$)| `sed -ne "s/^top_srcdir *=
*//p" < Makefile`/extras/buildsystem/make.pl
test -f .error\$\$ && ERROR=1
rm -f .error\$\$
exit \$ERROR" >compile

Else the double quote would terminate the first one after echo "

Does the error happen at configure or compile? With which shell?

BTW maybe we want to remove this script now that gcc got colored output
with version 4.9