[vlc-devel] [PATCH 3/9] swscale: bail out if 3D stereo conversion is requested

[Felix Abecassis]

2014-08-09 15:41 GMT+02:00 Vittorio Giovara <vittorio.giovara at gmail.com>:
> On Fri, Aug 8, 2014 at 7:13 PM, Felix Abecassis
> <felix.abecassis at gmail.com> wrote:
>> ---
>>  modules/video_chroma/swscale.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/modules/video_chroma/swscale.c b/modules/video_chroma/swscale.c
>> index 8ce512c..4b753da 100644
>> --- a/modules/video_chroma/swscale.c
>> +++ b/modules/video_chroma/swscale.c
>> @@ -362,6 +362,9 @@ static int Init( filter_t *p_filter )
>>      if( p_fmti->orientation != p_fmto->orientation )
>>          return VLC_EGENERIC;
>>
>> +    if( p_fmti->stereo_format.mode != p_fmto->stereo_format.mode )
>> +        return VLC_EGENERIC;
>> +
>>      if( video_format_IsSimilar( p_fmti, &p_sys->fmt_in ) &&
>>          video_format_IsSimilar( p_fmto, &p_sys->fmt_out ) &&
>>          p_sys->ctx )
>
> Seems ok but why?
>

When the vout cannot handle the stereo mode of the video format, the
core adds a video filter for converting between the two types (filter
stereo3d_convert in patch 4/9).
Without this patch, swscale will be picked (it has an higher priority
currently) and will perform no conversion.

> --
> Vittorio
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



-- 
Félix Abecassis
http://felix.abecassis.me