[vlc-devel] [PATCH 2/2] Win32: write module name as wchar_t

Rafaël Carré funman at videolan.org
Wed Aug 13 10:46:02 CEST 2014


On 08/12/14 22:22, Hannes Domani wrote:
>> Rafaël Carré <funman at videolan.org> schrieb am 19:13 Dienstag, 12.August 2014:
>>> --- a/bin/winvlc.c
>>> +++ b/bin/winvlc.c
>>> @@ -296,7 +296,7 @@ LONG WINAPI vlc_exception_filter(struct _EXCEPTION_POINTERS *lpExceptionInfo)
>>>           osvi.dwOSVersionInfoSize = sizeof( OSVERSIONINFO );
>>>           GetVersionEx( &osvi );
>>>
>>> -        fwprintf( fd, L"[version]\nOS=%d.%d.%d.%d.%s\nVLC=" VERSION_MESSAGE,
>>> +        fwprintf( fd, L"[version]\nOS=%d.%d.%d.%d.%ls\nVLC=" VERSION_MESSAGE,
>>>                   osvi.dwMajorVersion, osvi.dwMinorVersion, osvi.dwBuildNumber,
>>>                   osvi.dwPlatformId, osvi.szCSDVersion);
>>
>> The log message doesn't tell about this change, is it wanted?
> 
> Yes, szCSDVersion is a wchar_t* as well.
> Maybe better:
> Win32: use %ls for wchar_t strings

Yes that's better



More information about the vlc-devel mailing list