[vlc-devel] [PATCH 3/3] qt4: Add a 'virtual vs Q_DECL_OVERRIDE' section

[Tristan Matthews]

Hi,

On Thu, Aug 14, 2014 at 11:42 AM, Uwe L. Korn <uwelk at xhochy.com> wrote:
>
> This should explain when to use the virtual keyword or the
> Q_DECL_OVERRIDE macros on virtual function declarations.
> ---
>  modules/gui/qt4/HACKING | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/modules/gui/qt4/HACKING b/modules/gui/qt4/HACKING
> index bb642ca..60b8eb4 100644
> --- a/modules/gui/qt4/HACKING
> +++ b/modules/gui/qt4/HACKING
> @@ -43,6 +43,14 @@ So if your dialog is a dialog you are used to keep during a playing of a video,
>  QVLCFrame: extended panel, messages...
>  QVLCDialog: preferences, open...
>
> +** virtual vs Q_DECL_OVERRIDE **
> +Only mark functions with the virtual keyword if this is the inital virtual

"initial"

> +declaration. Functions that override a virtual function should have the
> +Q_DECL_OVERRIDE macro appended (which expands to the override identifier
> +when compiled with Qt5 and C++11). This is a visual indicator to distinguish
> +virtual declarations from overriding implementaions and will include a

"implementations"

> +compile-time check in C++11 language mode.
> +
>  ** HIG for Qt **
>  We tend to use GNOME/KDE specs over Vista ones for capitalizations:
>  We use Header for:
> --
> 2.0.4
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel