[vlc-devel] [PATCH 5/6] DirectDraw/Direct3D: make a clean copy of the

[Rémi Denis-Courmont]

Le jeudi 28 août 2014, 13:29:15 Hannes Domani a écrit :
> This is necessary for the cleanup of vd->source and vd->fmt later (next
> patch).

This is theoretically correct. But pragmatically, I think this scenario is 
hopeless. There are many remaining occurrences of the "same" bug. Indeed VLC 
code generally assumes that video_format_t is an immediate type.

The only reason why this would not be the case is the palette. This is rare 
enough that I think we should rather move the palette out of video_format_t 
than "fix" video format copies and deletions. Especially at the video output 
level, I am not aware of any video output plugin with palette support.

-- 
Rémi Denis-Courmont
http://www.remlab.net/