[vlc-devel] [PATCH 00/14] Samba navigation via libvlc

Jean-Baptiste Kempf jb at videolan.org
Sun Dec 7 17:07:35 CET 2014


Ping reviews.

On 05 Dec, Thomas Guillem wrote :
> - Extended services_discovery and libvlc_media_discoverer to enable browsing.
> 
> - Clean-up and refactor in access/dsm.
> 
> - Patched access/dsm/sd.c to handle browsing via
>   vlc_sd_Control(p_sd, SD_CMD_BROWSE, path).
> 
> - Patched access/dsm/sd.c to use a thread that handle commands sent via
>   vlc_sd_Control.
> 
> - Use netbios_ns_abort in order to abort the sd thread.
> 
> TODO: improve ns discovery that should search for share for more than 3
> seconds. It should search for shares until the services_discovery is ended or
> receive a new command via control. It should also send a ItemRemoved event when
> a share is not responding to broadcast for more than 10seconds (or more). 
> 
> 
> Thomas Guillem (14):
>   services_discovery: add SD_CMD_BROWSE
>   lib: change libvlc_media_discoverer_t creation
>   lib: add libvlc_media_discoverer_browse
>   lib: add new libvlc_MediaDiscoverer events
>   Require libdsm > 0.0.3
>   contrib: fix libdsm and libtasn1 rules
>   contrib: change libdsm URL
>   contrib: update libdsm to 0.0.3
>   dsm: refactor
>   dsm: only one function to browse share and directory
>   dsm: add "smb://" if not present
>   dsm/sd: discover in a separate thread and handle commands
>   dsm: don't use netbios struct members directly
>   dsm: use NETBIOS_FILESERVER define
> 
>  configure.ac                          |   2 +-
>  contrib/src/libdsm/SHA512SUMS         |   2 +-
>  contrib/src/libdsm/rules.mak          |   7 +-
>  contrib/src/libtasn1/rules.mak        |   2 +
>  include/vlc/libvlc_events.h           |  13 +
>  include/vlc/libvlc_media_discoverer.h |  40 ++-
>  include/vlc_services_discovery.h      |   3 +-
>  lib/libvlc.sym                        |   4 +
>  lib/media_discoverer.c                | 106 ++++++-
>  modules/access/Makefile.am            |   2 +-
>  modules/access/dsm/access.c           | 361 +++-------------------
>  modules/access/dsm/browser.c          | 191 ------------
>  modules/access/dsm/common.c           | 559 ++++++++++++++++++++++++++++++++++
>  modules/access/dsm/common.h           |  17 +-
>  modules/access/dsm/sd.c               | 202 ++++++++++--
>  15 files changed, 945 insertions(+), 566 deletions(-)
>  delete mode 100644 modules/access/dsm/browser.c
>  create mode 100644 modules/access/dsm/common.c
> 
> -- 
> 2.1.3
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-- 
With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device



More information about the vlc-devel mailing list