[vlc-devel] [PATCH 01/14] services_discovery: add SD_CMD_BROWSE

[Rémi Denis-Courmont]

Le vendredi 05 décembre 2014, 14:42:52 Thomas Guillem a écrit :
> ---
>  include/vlc_services_discovery.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/vlc_services_discovery.h
> b/include/vlc_services_discovery.h index d9c231b..3e84952 100644
> --- a/include/vlc_services_discovery.h
> +++ b/include/vlc_services_discovery.h
> @@ -82,7 +82,8 @@ enum services_discovery_category_e
>  enum services_discovery_command_e
>  {
>      SD_CMD_SEARCH = 1,          /**< arg1 = query */
> -    SD_CMD_DESCRIPTOR           /**< arg1 =
> services_discovery_descriptor_t* */
> +    SD_CMD_DESCRIPTOR,          /**<
> arg1 = services_discovery_descriptor_t* */
> +    SD_CMD_BROWSE              
> /**< arg1 = const char *psz_path */ };

I don't see how that can work.

The SD plugins are operating with items, not with URIs. So they would need the 
item and an opaque data pointer associated with that item.

Even then, it is very unclear what that new control does.

> 
>  /**

-- 
Rémi Denis-Courmont
http://www.remlab.net/