[vlc-devel] [PATCH] realloc: use realloc_or_free() to avoid memory leak

[Arjun Sreedharan]

On 10 December 2014 at 22:19, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le mercredi 10 décembre 2014, 22:17:32 Arjun Sreedharan a écrit :
>> On 10 December 2014 at 20:19, Rémi Denis-Courmont <remi at remlab.net> wrote:
>> > Le 2014-12-10 17:35, Arjun Sreedharan a écrit :
>> >> overwriting pointer with realloc()'s return value can leak memory
>> >> when realloc() fails. realloc_or_free() manages this and frees memory
>> >> on failure.
>> >
>> > Did you actually test this? Some of the snippets don't look right.
>>
>> It compiled fine.
>> Could you point out what looks wrong to you.
>
> I checked only one snippet and it was introducing a double free() bug rather
> than fixing anything...

Could you please annotate that line. I was unable to spot

>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel