[vlc-devel] [RFC PATCH] Direct rendering spu placement
remi at remlab.net
Wed Dec 31 19:04:11 CET 2014
Le 2014-12-29 20:46, Thomas Guillem a écrit :
> Hello, I need your opinions about this patch/question.
> I have an issue when displaying an HD video on a display of
> Here is the example: with a 1916x1076 video on a 1200x1920 display.
> The place
> returned by vout_display_PlacePicture is 1200x673, which is good, but
> smaller than the video size, so it's not used.
> So, do you think it's safe to remove the following check ?
> (fmt_spu.i_width * fmt_spu.i_height < place.width * place.height)"
git-blame points at:
Author: Laurent Aimar <fenrir at videolan.org>
Date: Thu Apr 14 22:45:34 2011 +0200
Improved subtitiles/OSD quality when the rendering is done by the
vout display module.
In this case, the subpictures are rendered either at the display
the video size (the biggest one).
> I don't see any problems with having a spu size smaller than the
> video size.
The code thrives for the best quality option. In my opinion, the video
size should always be used because that's the only clean and race-free
option - even though that will reduce quality on low resolution videos.
I fail to see any advantage to your patch.
More information about the vlc-devel