[vlc-devel] [vlc-commits] Added coreanimation opengl layer vout module

[Rafaël Carré]

Hello,

On 02/04/14 13:13, Felix Paul Kühne wrote:
> Hello,
> 
> On 03.02.2014, at 12:44, David Fuhrmann <git at videolan.org> wrote:
> 
>> vlc | branch: master | David Fuhrmann <david.fuhrmann at googlemail.com> | Mon Feb  3 12:38:25 2014 +0100| [254a5ee275d526364e7eebb1ae63c0fb71127f16] | committer: David Fuhrmann
>>
>> Added coreanimation opengl layer vout module
>>
>> This module is used for video output with the windowed npapi plugin.
> 
> Looks like we really need a configure switch here or more magic in the configure script itself to distinguish builds for iOS from builds for OS X. So far, both receive HAVE_DARWIN, which is technically correct but leads to the issue that this Mac-only module is attempted to be compiled for iOS, which is a pretty bad idea (it won't work and won't even compile in the first place).
> 
> I'm absolutely open to any suggestions.

Test for the features used by this module, and which won't build on iOS.

You can check for headers or even build a code sample with
AC_COMPILE_IFELSE.

> Best regards,
> 
> Felix