[vlc-devel] [PATCH] Support for rotated MP4 Movies (bug #2882)
jb at videolan.org
Fri Feb 7 15:05:47 CET 2014
On 06 Feb, Matthias Keiser wrote :
> - if( MP4_BoxCount( p_sys->p_root, "/moov/mvex" ) > 0 )
> + if( MP4_BoxCount( p_sys->p_root, "/moov/mvex" ) > 0 && MP4_BoxCount( p_sys->p_root, "/moof" ) > 0)
> + //FIXME: relying on STREAM_CAN_FASTSEEK to decide if we can parse
> + // a file is a bad heuristic, because local files are always
> + // fast-seekable.
So? I don't get this comment.
> + //FIXME: This means that avformat will take over, but it doesn't do a better job than we if the file is not seekable.
Then the discarding should be removed, in a different set of patches.
With my kindest regards,
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device
More information about the vlc-devel