[vlc-devel] [PATCH] Support for rotated MP4 Movies (bug #2882)

[Rémi Denis-Courmont]

Le vendredi 7 février 2014, 15:14:45 Rémi Denis-Courmont a écrit :
> On Thu, 6 Feb 2014 23:20:10 +0100, Matthias Keiser
> 
> <matthias at tristan-inc.com> wrote:
> > From 0d66fd5d7a4c57f70bf6968b03fa313f3be1fcad Mon Sep 17 00:00:00 2001
> > From: Matthias Keiser <matthias at tristan-inc.com>
> > Date: Thu, 6 Feb 2014 16:17:34 +0100
> > Subject: [PATCH 08/13] video_format_IsSimilar: check orientation.
> > 
> > ---
> > 
> >  src/misc/es_format.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/src/misc/es_format.c b/src/misc/es_format.c
> > index 566203f..88447c0 100644
> > --- a/src/misc/es_format.c
> > +++ b/src/misc/es_format.c
> > @@ -279,6 +279,9 @@ bool video_format_IsSimilar( const video_format_t
> > *p_fmt1, const video_format_t
> > 
> >      if( v1.i_sar_num * v2.i_sar_den != v2.i_sar_num * v1.i_sar_den )
> >      
> >          return false;
> > 
> > +    if( v1.orientation != v2.orientation)
> > +        return false;
> > +
> 
> That is correct. But I doubt that all existing call sites in the code base
> will cope with the change out of the box.

Merged, but this will need fixes.

-- 
Rémi Denis-Courmont
http://www.remlab.net/