[vlc-devel] [PATCH 3/4] vout: use variable "zoom" instead of "scale"

[Felix Abecassis]

Looking at vout_intf.c, the "zoom" callback simply forward the new value to
"scale".
With the latest git version --zoom is working and --scale does nothing.
With 2.0.8 release, --zoom does nothing and --scale is working.

So I'm also confused by what the difference *should* be.


2014-02-11 9:29 GMT+01:00 Rémi Denis-Courmont <remi at remlab.net>:

> n Mon, 10 Feb 2014 19:14:52 +0100, Felix Abecassis
> <felix.abecassis at gmail.com> wrote:
> > ---
> >  src/video_output/video_output.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/video_output/video_output.c
> > b/src/video_output/video_output.c
> > index 1fe3acf..629b8d2 100644
> > --- a/src/video_output/video_output.c
> > +++ b/src/video_output/video_output.c
> > @@ -592,7 +592,7 @@ static void VoutGetDisplayCfg(vout_thread_t *vout,
> > vout_display_cfg_t *cfg, cons
> >      cfg->display.sar.num = msar_num;
> >      cfg->display.sar.den = msar_den;
> >      unsigned zoom_den = 1000;
> > -    unsigned zoom_num = zoom_den * var_CreateGetFloat(vout, "scale");
> > +    unsigned zoom_num = zoom_den * var_CreateGetFloat(vout, "zoom");
>
> This may fix zoom, but does not this break scale? The distinction has
> always been confusing to me.
>
> >      vlc_ureduce(&zoom_num, &zoom_den, zoom_num, zoom_den, 0);
> >      cfg->zoom.num = zoom_num;
> >      cfg->zoom.den = zoom_den;
>
> --
> Rémi Denis-Courmont
> Sent from my collocated server
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>



-- 
Félix Abecassis
http://felix.abecassis.me
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140211/cafcd087/attachment.html>