[vlc-devel] [PATCH 3/4] vout: use variable "zoom" instead of "scale"

[Felix Abecassis]

2014-02-11 13:59 GMT+01:00 Rémi Denis-Courmont <remi at remlab.net>:

> On Tue, 11 Feb 2014 10:34:10 +0100, Felix Abecassis
> <felix.abecassis at gmail.com> wrote:
> > Looking at vout_intf.c, the "zoom" callback simply forward the new value
> to
> > "scale".
> > With the latest git version --zoom is working and --scale does nothing.
>
> Scale should only have an effect if autoscale is disabled, so that is not
> necessarily wrong.
>
Scale cannot work with the current code I think. If you have a use case
where it does, I'm interested.
The zoom callback has the following statement: var_SetFloat( obj, "scale",
cur.f_float );
The scale callback is not currently triggered from vout_IntfReinit, even if
it was it won't work.
If we trigger the zoom callback first, we will erase the previous value of
scale.
If we trigger the scale callback first, we will send a zoom event but the
zoom callback will send another zoom event cancelling the first one.



> I think zoom affects the (requested) video window size, while scale
> affects the video area size within the video window. Zoom is intended for
> use with autoscale, which is enabled by default. Using both zoom and scale
> simultaneous makes little practical sense, so it is theoretically possible
> to define it (zoom affects the window, scale affects the video area).
>
Since in both cases (scale and zoom) we call vout_ControlChangeZoom, I
don't see how this could work currently.
Without autoscale, It looks like zoom has the behaviour you are describing
for "scale".

-- 
Félix Abecassis
http://felix.abecassis.me
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140211/21e7772b/attachment.html>