[vlc-devel] [PATCH] Add a libvlc_set_video_output function

[Rémi Denis-Courmont]

On Wed, 12 Feb 2014 18:54:28 -0500, Edward Wang
<edward.c.wang at compdigitec.com> wrote:
> On 2014-02-11 17:57, Hugo Beauzée-Luyssen <hugo at beauzee.fr> wrote:
>>> never depended on which video output plugin was used (though it
depends
>>> on
>>> >windowing system - that is unavoidable). Worse yet, your patch is of
>>> >absolutely no use in portable code, since the possible values are
>>> >system-
>>> >specific.
>>> >
>> I think this is up to libvlc user to take care of this, just like it's
>> the case for the libvlc_media_player_set_{xwindow,hwnd,nsobject}
>> functions.
> 
> Having the ability to allow the libvlc applications to override and 
> select a custom video output would also grant greater flexibility in 
> overcoming platform bugs.

The patch does not do that. The patch has no way to enumerate available
plugins.

Also the patch interferes with set_xid and set_video_callbacks functions.

> We can't expect VideoLAN to fix all the driver bugs on all platforms 
> either, so maybe this should be prefixed with a prominent warning that 
> if you do this and things go horribly wrong, you can't blame libvlc for 
> this.

We do not add unsupported functions to the API; this is ridiculous.
libvlc_new() parameters are unsupported but still present 1/ because vlc
and cachegen knowingly use them and 2/ for calling convention backward
compatibility. Neither of these justfications exist for adding a a function
that would be unsupported from the starting point.

And really, you cannot tell developers that there is this function we just
added, but do not use it. It does not make sense. That's pure bloat an
confusion.

-- 
Rémi Denis-Courmont
Sent from my collocated server