[vlc-devel] [PATCH 1/2/ input core add status field per elementary strean

[Rémi Denis-Courmont]

Le samedi 15 février 2014, 14:34:20 Denis Charmet a écrit :
> Hi,
> 
> Le samedi 15 février 2014 à 01:37:58, Rémi Denis-Courmont a écrit :
> > This is obviously not thread-safe.
> 
> I'm surely missing something but why is it not thread-safe?

Did you actually check *where* the p_dec->b_error was read and written?
This cannot work.

> Isn't calling it from ESOutControlLocked enough?

I fail to see how that helps in any way.

> > (And it seems to contradict the plan for S/PDIF autodetection too.)
> 
> What's the plan for S/PDIF autodetection?

Decoder handles audio output errors.

-- 
Реми Денис-Курмон
http://www.remlab.net/