[vlc-devel] RFC decoder b_pace_control field

[Rafaël Carré]

On 02/15/14 14:41, Denis Charmet wrote:
> Hi,
> 
> It looks like avcodec module silently drop video frames.

The first step should be to add an error message in these cases IMO.

> While looking
> at it I found out that it checks for p_dec->b_pace_control which is only
> set in src/misc/images but not in src/input/decoder.c
> 
> Shouldn't there be something like that in decoder_New
> 
> --- a/src/input/decoder.c
> +++ b/src/input/decoder.c
> @@ -289,6 +289,8 @@ static decoder_t *decoder_New( vlc_object_t
> *p_parent, input
>          return NULL;
>      }
>  
> +    p_dec->b_pace_control = var_GetBool( p_input, "can-rate" );z
>      return p_dec;
>  }
> 
> Or am I missing the whole point of this flag?

According to Ilkka this is an old hack that is only used by avcodec and
libmpeg2 to
ignore late frames when decoding a single picture.