[vlc-devel] [PATCH 1/3] input core: add status field per elementary stream
remi at remlab.net
Mon Feb 17 09:58:27 CET 2014
On Mon, 17 Feb 2014 08:32:05 +0200, Ilkka Ollakka <ileoo at videolan.org>
> On Sun, Feb 16, 2014 at 10:51:49AM +0200, Rémi Denis-Courmont wrote:
>> Already explained that this makes no sense *yesterday*. Not doing it
> You had good points for previous patch, and I think in this patch the
> thread safety is handled with use of atomic variable.
Atomic is not some magic key word that you sprinkle over the code base to
give sense to code. As already written, the first patch was just undefined
behaviour and the second patch is unspecified result. Better? yes. Useful?
> We talked about these patches and it could be that this approach isn't
> the most ideal overall, but in that case it's good starting point to
> check the issue it focuses on resolving.
This patch is obviously useless and evidently not thought through.
Thinking stuff through is the responsibility of the patch author. It is
understandable that newbies fail to do this. It is understandable that
experienced developers sometimes fail to do this. But I am fed up with
Jean-Paul consistently failing to do it for whatever reasons.
This is not acceptable and I am not wasting more of my free time on this.
Sent from my collocated server
More information about the vlc-devel