[vlc-devel] [PATCH 2/7] Support for rotated MP4 Movies (bug #2882)

[Rémi Denis-Courmont]

On Mon, 17 Feb 2014 09:59:04 +0100, Matthias Keiser
<matthias at tristan-inc.com> wrote:
> Am 17.02.2014 um 09:47 schrieb Rémi Denis-Courmont <remi at remlab.net>:
> 
>> I already told you it cannot ever work that way. Chicken and egg.
> 
> You wrote "depending on what I mean", so that is what I mean. 
> Could you give additional hints as to what exactly the chicken and egg
> problem is here?

When would you invoke the new control request? You cannot call it until
after the video output plugin has been activated, and yet by that point,
the video format is already fixed... So that looks like a catch-22
situation.

I would rather follow the existing pattern: you supply the format assuming
the video output plugin *supports* orientation. If the video output plugin
does *not* support rotation, the plugin shall call
video_format_ApplyRotation() to undo it. Obivously, the patch is a lot more
invasive and tedious, but that is how VLC video output works so far.

-- 
Rémi Denis-Courmont
Sent from my collocated server