[vlc-devel] [PATCH 7/7] Support for rotated MP4 Movies (bug #2882)

[Rémi Denis-Courmont]

On Mon, 17 Feb 2014 01:38:03 +0100, Matthias Keiser
<matthias at tristan-inc.com> wrote:
> +        else if (ORIENT_IS_SWAP(vout->p->filter.format.orientation)) {
> +
> +            //If we don't use a filter, we have to adjust the aspect
> ration manually.
> +            ThreadChangeAspectRatio(vout,
> vout->p->filter.format.i_visible_height,
> vout->p->filter.format.i_visible_width);

Won't this clobber the user-set or decoder-specified aspect ratio?
Won't this reduce picture quality on non-scaling display plugins?

> +        }
> +    }
> +
>      char *current = filters ? strdup(filters) : NULL;
>      while (current) {
>          config_chain_t *cfg;

-- 
Rémi Denis-Courmont
Sent from my collocated server