[vlc-devel] [#10696] Build fails on GNU/Hurd

[Rafaël Carré]

Hello,

On 02/18/14 03:08, Gabriele Giacone wrote:
> Following up https://trac.videolan.org/vlc/ticket/10696
> 
> Hello,
> 
> courmisch wrote:
>> The OSS patch results in unconditionnaly undefined behaviour, not to
>> mention that I do not see the point disabling calls mandatory in the OSSv4
>> specification.
>> The VCD patch does not seem to make any sense either.
> 
> I'm aware my patches ifdef'ing ioctls are more than ugly,

Good that you're aware :)

> but
> currently GNU/Hurd has no sound support at all and there are no plans
> about working on it.

Why do you need OSS then?

Do you have some emulation sending the audio from /dev/dsp to somewhere
else ?

> To get a successful build, hurd.diff was enough (thread + OSS
> patches). Then given current Debian packaging considers CDDA enabled
> on all archs, I added hurd02.diff to enable CDDA (CDDA patch) and make
> the build succeed again (VCD patch).

Did you actually test VCD ?

>> The thread patch makes no sense to me since _POSIX_TIMERS <= 0
>> is already addressed at the beginning of the file.
> 
> As far as I understand, Hurd case is not addressed well.
> Both _POSIX_MONOTONIC_CLOCK and _POSIX_CLOCK_SELECTION >0 implies
> _POSIX_TIMERS >0.
> On Hurd, _POSIX_TIMERS equals to 0 (see [1]), patch adds a
> _POSIX_TIMERS check to not match _POSIX_CLOCK_SELECTION >0 only case.

Can you post your build error?

> If I'm wrong, I could replace them with __GNU__ ifdefs.
> 
> [1] http://sources.debian.net/src/eglibc/2.17-93/sysdeps/mach/hurd/bits/posix_opt.h?hl=154#L153
> 
> Thanks,