[vlc-devel] [#10696] Build fails on GNU/Hurd

[Rémi Denis-Courmont]

On Tue, 18 Feb 2014 03:08:44 +0100, Gabriele Giacone <1o5g4r8o at gmail.com>
wrote:
> Following up https://trac.videolan.org/vlc/ticket/10696
> 
> Hello,
> 
> courmisch wrote:
>> The OSS patch results in unconditionnaly undefined behaviour, not to
>> mention that I do not see the point disabling calls mandatory in the
>> OSSv4
>> specification.
>> The VCD patch does not seem to make any sense either.
> 
> I'm aware my patches ifdef'ing ioctls are more than ugly, but
> currently GNU/Hurd has no sound support at all and there are no plans
> about working on it.

Then don't build the OSS plugin!

> To get a successful build, hurd.diff was enough (thread + OSS
> patches). Then given current Debian packaging considers CDDA enabled
> on all archs, I added hurd02.diff to enable CDDA (CDDA patch) and make
> the build succeed again (VCD patch).

I do not want to build deliberately dysfunctional plugins, especially if
that means cluttering said plugins with ifdefs.
Please take Debian packaging issues to the Debian Multimedia maitainers.
Most of them are not even on this mailing list.

>> The thread patch makes no sense to me since _POSIX_TIMERS <= 0
>> is already addressed at the beginning of the file.
> 
> As far as I understand, Hurd case is not addressed well.
> Both _POSIX_MONOTONIC_CLOCK and _POSIX_CLOCK_SELECTION >0 implies
> _POSIX_TIMERS >0.

Of course. POSIX clock selection *depends* on POSIX timers as does the
POSIX monotonic clock. The CLOCK_* values are defined by POSIX timers, so
it would make no sense otherwise.

> On Hurd, _POSIX_TIMERS equals to 0 (see [1]),

Zero means that the functions and macros are provided but might not work
at run-time. The VLC code goes to great length to support run-time
detection correctly.

-- 
Rémi Denis-Courmont
Sent from my collocated server