[vlc-devel] [PATCH] Support the Metacube protocol when streaming over HTTP.

Denis Charmet typx at dinauz.org
Tue Feb 18 11:07:19 CET 2014

Le mardi 18 février 2014 à 10:31:46, Steinar H. Gunderson a écrit :
> >> +    static const int data_len = sizeof(hdr->size) + sizeof(hdr->flags);
> > why static?
> Because it's a compile-time constant?
I tend to assume that static actually takes space in the data segment and
that const is enough when everything is evaluated at the compile time.
Well gcc proved me wrong for the first assertion, my bad.

> > use C99, you can declare your variable inside your for.
> Note that this code is cut-and-pasted from upstream code. But I can change it
> if you're happy with it diverging (I already changed the indentation).
Well it started diverging the moment you pasted it :) Personally I don't


Denis Charmet - TypX
Le mauvais esprit est un art de vivre

More information about the vlc-devel mailing list