[vlc-devel] [PATCH] Allow hevc muxing in mp4

[Rafaël Carré]

On 02/24/14 13:31, Denis Charmet wrote:
> Hi,
> 
> Le lundi 24 février 2014 à 10:01:19, Rafaël Carré a écrit :

>>>                  p_data = ConvertAVC1(p_data);
>>
>> Maybe function name should be changed?
>>
> If you have one, I'm taking it.

ConvertNAL / ConvertFromAnnexB

>>> +/*
>>> +The following table comes from iso/iec 14496-15 3rd edition
>>> +
>>> [...]
>>> +*/
>>
>> Is this description your own work ?
>>
> As stated in the comment no it's not.

I am not sure if it can be copy/pasted in a (L)GPL file then.

The document should have a copyright statement to clarify this.

>>> +static void hevcParseVPS(uint8_t * p_buffer, size_t i_buffer, uint8_t *general,
>>> +                         uint8_t * numTemporalLayer, bool * temporalIdNested)
>>> +{
>>> +    const size_t i_decoded_nal_size = 512;
>>
>> Magic value?
>>
> Big enough value, I'm too lazy to actually calculate what's the worst
> case with the 0x03 emulation bytes and all the flags... And this
> prevents malloc.

hm maybe we need an error message if this overflows.

>>> +    uint8_t p_dec_nal[i_decoded_nal_size];
>>> +    size_t i_size = (i_buffer < i_decoded_nal_size)?i_buffer:i_decoded_nal_size;
>>> +    nal_decode(p_buffer, p_dec_nal, i_size);
>>> +
>>> +    /* first two bytes are the NAL header 3rd and 4th are:
>>
>> Comma before "3rd" ?
>>
> Srsly?

Yeah I think it's more clear this way.. and as you saw I only send
nitpickings :)

>>> +    if (p_stream->fmt.i_extra > 0) {
>>
>> if (!p_stream->fmt.i_extra)
>> 	return hvcC;
>>
> pfff ok

This doesn't waste precious horizontal space

> Regards,
>