[vlc-devel] [PATCH 3/6] Support for displaying rotated movies.

[Rémi Denis-Courmont]

Le vendredi 28 février 2014, 20:57:54 Matthias Keiser a écrit :
> What should we do then? Are we allowed to change vd->fmt to something
> different? Btw, currently, if filter creation fails, nothing is done about
> it except an error log.

It might be easier to handle every combination than to handle the error. But 
otherwise you need to handle the error safely somehow.

> > IMNSHO, this belongs in the chain filter, not in the core anyway.
> > Otherwise, I fear this will break transcode.
> 
> Sorry, I don't know what the "chain filter" is. Do you mean the filter
> chain?

I mean modules/video_chroma/chain.c; the plugin splitting non-trivial video 
format conversions.

-- 
Rémi Denis-Courmont
http://www.remlab.net/