[vlc-devel] [vlc-commits] date_Decrement: change assert so it doesn't to funky stuff

Ilkka Ollakka ileoo at videolan.org
Sat Jan 4 14:16:01 CET 2014

On Sat, Jan 04, 2014 at 02:13:41PM +0100, Ilkka Ollakka wrote:
> vlc | branch: master | Ilkka Ollakka <ileoo at videolan.org> | Wed Dec 11 09:02:49 2013 +0200| [4e6c9e082db20a723154dc79d604092fc120c146] | committer: Ilkka Ollakka

> If we do date_Set and right after that date_Decrement that assert
> seemed to behave differently in 64bit and 32bit architectures.

> -        assert( p_date->i_remainder > -p_date->i_divider_num);
> +        assert( p_date->i_remainder < p_date->i_divider_num);

I'm not 100% sure about this one, but the original assert seemed to act
funny if i_remainder was 0. And Date_Decrement wasn't really used that much
so not sure if it was ever tested for such case when it was included in
dirac codec (where it was moved to core).

Ilkka Ollakka
There is hardly a thing in the world that some man can not make a little
worse and sell a little cheaper.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140104/f75a1f51/attachment.sig>

More information about the vlc-devel mailing list