[vlc-devel] [PATCH 3/3] mediacodec: implementation of MediaCodec direct rendering based on the work by Martin Storsjö.

Rémi Denis-Courmont remi at remlab.net
Wed Jan 15 04:13:45 CET 2014

On Tue, 14 Jan 2014 12:11:14 +0100, Felix Abecassis
<felix.abecassis at gmail.com> wrote:
> Sorry to bump this thread again but I want to get this over with.
> This is my last attempt to try to convince you to have IsExitRequested
> moved to the API in order to be able to use it for MediaCodec DR,
> otherwise I have another option left to solve the bug but it looks
> hacky.

I still fail to see how having a check for exit will solve the sleeping
and waking up problem (polite way of saying it cannot solve it). And no,
putting video output specific code in the decoder API does not look
acceptable to me, especially not if it does not even theoretically solve
the problem it is supposed to.

> - We should put a warning in the code to warn other developers not to
> copy/paste this piece of code in order to preserve transcoding.

If it were about me, I would agree to that. But recent and old threads in
the mailing list show that more than one active developper here ignore code
comments, even right next to the code. I cannot fix that, and nor can you.

Rémi Denis-Courmont
Sent from my collocated server

More information about the vlc-devel mailing list