[vlc-devel] [PATCH] Remove dirac.c

[Jean-Baptiste Kempf]

LGTM.

On 15 Jan, Rafaël Carré wrote :
> Comment says:
> "NB, this is a temporary encoder only module until schroedinger
> offers superior encoding quality than dirac-research"
> 
> http://diracvideo.org/2012/01/schroedinger-1-0-11/ says:
> "Schrödinger outperforms dirac-research in most encoding situations,
> both in terms of encoding speed and visual quality."
> ---
>  configure.ac              |   5 -
>  modules/MODULES_LIST      |   1 -
>  modules/codec/Makefile.am |   7 -
>  modules/codec/dirac.c     | 981 ----------------------------------------------
>  po/POTFILES.in            |   1 -
>  5 files changed, 995 deletions(-)
>  delete mode 100644 modules/codec/dirac.c
> 
> diff --git a/configure.ac b/configure.ac
> index 2d1ba6b..cc5c5c9 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2671,11 +2671,6 @@ dnl
>  PKG_ENABLE_MODULES_VLC([THEORA], [], [ogg theoradec >= 1.0 theoraenc], [experimental theora codec], [auto])
>  
>  dnl
> -dnl  dirac encoder plugin
> -dnl
> -PKG_ENABLE_MODULES_VLC([DIRAC], [], [dirac >= 0.10.0], [dirac encoder], [auto])
> -
> -dnl
>  dnl  schroedinger decoder plugin (for dirac format video)
>  dnl
>  PKG_ENABLE_MODULES_VLC([SCHROEDINGER], [], [schroedinger-1.0 >= 1.0.10], [dirac decoder and encoder using schroedinger], [auto])
> diff --git a/modules/MODULES_LIST b/modules/MODULES_LIST
> index 5079f22..1375b32 100644
> --- a/modules/MODULES_LIST
> +++ b/modules/MODULES_LIST
> @@ -84,7 +84,6 @@ $Id$
>   * demux_cdg: Demuxer for CD-G files (Karaoke)
>   * demux_stl: EBU STL subtitles demuxer
>   * demuxdump: Pseudo-demuxer that dumps the stream
> - * dirac: BBC Dirac codec
>   * diracsys: BBC Dirac demuxer
>   * direct2d: video output module using the Direct2D API
>   * direct3d: video output module using the Direct3D API
> diff --git a/modules/codec/Makefile.am b/modules/codec/Makefile.am
> index 9673d04..e45174c 100644
> --- a/modules/codec/Makefile.am
> +++ b/modules/codec/Makefile.am
> @@ -388,13 +388,6 @@ codec_LTLIBRARIES += $(LTLIBx26410b)
>  
>  ### Misc encoders ###
>  
> -libdirac_plugin_la_SOURCES = codec/dirac.c
> -libdirac_plugin_la_CFLAGS = $(AM_CFLAGS) $(DIRAC_CFLAGS)
> -libdirac_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(codecdir)'
> -libdirac_plugin_la_LIBADD = $(DIRAC_LIBS)
> -EXTRA_LTLIBRARIES += libdirac_plugin.la
> -codec_LTLIBRARIES += $(LTLIBdirac)
> -
>  libfdkaac_plugin_la_SOURCES = codec/fdkaac.c
>  libfdkaac_plugin_la_CFLAGS = $(AM_CFLAGS) $(FDKAAC_CFLAGS)
>  libfdkaac_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(codecdir)'
> diff --git a/modules/codec/dirac.c b/modules/codec/dirac.c
> deleted file mode 100644
> index 36d8262..0000000
> diff --git a/po/POTFILES.in b/po/POTFILES.in
> index 9cab7e5..5e75a6e 100644
> --- a/po/POTFILES.in
> +++ b/po/POTFILES.in
> @@ -361,7 +361,6 @@ modules/codec/cdg.c
>  modules/codec/crystalhd.c
>  modules/codec/cvdsub.c
>  modules/codec/ddummy.c
> -modules/codec/dirac.c
>  modules/codec/dmo/buffer.c
>  modules/codec/dmo/dmo.c
>  modules/codec/dmo/dmo.h
> -- 
> 1.8.5.3
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-- 
With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device