[vlc-devel] [vlc-commits] Use str_format_meta for snapshots

Rafaël Carré funman at videolan.org
Fri Jan 17 08:25:44 CET 2014

On 01/17/14 03:15, Rémi Denis-Courmont wrote:
> On Thu, 16 Jan 2014 22:01:12 +0100 (CET), git at videolan.org (Rafaël Carré)
> wrote:
>> vlc | branch: master | Rafaël Carré <funman at videolan.org> | Thu Jan 16
>> 22:00:52 2014 +0100| [17818d7bce710b281bc9d012aaf84a18b59924e2] |
>> committer: Rafaël Carré
>> Use str_format_meta for snapshots
> The vout outlives the subsequent inputs, so this is obviously invalid. The
> pointer is potentially dangling there.

The vout indeed survives subsequent inputs but its configuration is
updated (see vout_Request) so vout->p->input should stay valid.

Since update is made by the input itself (decoder) there is no need to
hold a reference to the input either.

> Please remove this commit.

Sorry but I am not convinced this should be removed, as far as I can
tell the vout references the input properly.

More information about the vlc-devel mailing list