[vlc-devel] [vlc-commits] Use str_format_meta for snapshots

[Rémi Denis-Courmont]

On Fri, 17 Jan 2014 08:35:07 +0100, Rafaël Carré <funman at videolan.org>
wrote:
> On 01/17/14 08:32, Rémi Denis-Courmont wrote:
>> On Fri, 17 Jan 2014 08:25:44 +0100, Rafaël Carré <funman at videolan.org>
>> wrote:
>>> On 01/17/14 03:15, Rémi Denis-Courmont wrote:
>>>> On Thu, 16 Jan 2014 22:01:12 +0100 (CET), git at videolan.org (Rafaël
>>>> Carré)
>>>> wrote:
>>>>> vlc | branch: master | Rafaël Carré <funman at videolan.org> | Thu Jan
>>>>> 16
>>>>> 22:00:52 2014 +0100| [17818d7bce710b281bc9d012aaf84a18b59924e2] |
>>>>> committer: Rafaël Carré
>>>>>
>>>>> Use str_format_meta for snapshots
>>>>
>>>> The vout outlives the subsequent inputs, so this is obviously
invalid.
>>>> The
>>>> pointer is potentially dangling there.
>>>
>>> The vout indeed survives subsequent inputs but its configuration is
>>> updated (see vout_Request) so vout->p->input should stay valid.
>> 
>> Of course not. First that does not solve the synchronization of memory
>> access to the pointer. 
> 
> That's true but that is not the issue you pointed out.

Yes it is. The pointer is undefined by the standard.

-- 
Rémi Denis-Courmont
Sent from my collocated server