[vlc-devel] [PATCH 2/3] Add MusicBrainzAlbumID to the metadata

Wieland Hoffmann themineo at gmail.com
Fri Jan 17 19:16:33 CET 2014

Hallo Jean-Baptiste Kempf:
> On 17 Jan, Wieland Hoffmann wrote :
> > +    vlc_meta_MusicBrainzAlbumID
> >  } vlc_meta_type_t;
> NAME too long, tbh.

How does vlc_meta_MB_AlbumID (or simply vlc_meta_AlbumID) sound?

> And do we need it as a main Meta? or can't we use it as an extra one?

Well, as mentioned before, saving them as extra tags would mean to
either not normalise the tag names and thereby force all code using the
ID to do that normalisation itself OR normalising the names which would
mean that this one specific track would get extra treatment compared to
the other extra tags, whose key in extra_tags is basically their name in
the file. AFAICT vlc_meta_type_t is currently used for all tags that get
such special treatment.


More information about the vlc-devel mailing list