[vlc-devel] [PATCH] Possible buffer overflow in vlc_readdir (fixes #9676)

Iwao AVE! harawata at gmail.com
Mon Jan 20 16:41:55 CET 2014


Hi Steinar,

I am not sure if we need to take six bytes utf-8 in account in this
particular case, but I will change it to 6.

Thank you for the advice!
Iwao

2014/1/20 Steinar H. Gunderson <sgunderson at bigfoot.com>:
> On Mon, Jan 20, 2014 at 11:15:06PM +0900, Iwao AVE! wrote:
>> +#ifdef __APPLE__
>> +    /*
>> +     * The returned value is in characters instead of bytes.
>> +     * Each character could occupy 4 bytes in UTF-8.
>> +     */
>> +    len *= 4;
>> +#endif
>
> A Unicode code point can occupy up to six bytes in UTF-8.
>
> Assuming, of course, that they mean Unicode code points by “character”
> in the first place, and not something more complicated.
>
> /* Steinar */
> --
> Homepage: http://www.sesse.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list