[vlc-devel] [vlc-commits] Fix wrong implicit cast
Rémi Duraffort
ivoire at videolan.org
Mon Jan 20 18:36:56 CET 2014
>> Fix wrong implicit cast
>
> Care to explain what is "wrong" in the implicit cast? Surely, we are
> not
> removing all implicit casts!
For the ones interested, this is a warning from clang:
CC audio_mixer/libinteger_mixer_plugin_la-integer.lo
../../modules/audio_mixer/integer.c:54:29: warning: signed shift result
(0x7FFFFFFF000000) requires 56 bits to represent, but 'int' only has 32
bits [-Wshift-overflow]
if (s >= (INT32_MAX << INT64_C(24)))
~~~~~~~~~ ^ ~~~~~~~~~~~
../../modules/audio_mixer/integer.c:57:28: warning: signed shift result
(0x80000000000000) requires 56 bits to represent, but 'int' only has 32
bits [-Wshift-overflow]
if (s < (INT32_MIN << INT64_C(24)))
~~~~~~~~~ ^ ~~~~~~~~~~~
Rgds
--
Rémi Duraffort
http://ivoire.dinauz.org/blog
More information about the vlc-devel
mailing list