[vlc-devel] [PATCH] avformat: use avcodec codec_tag as original fourcc

[Daniel Verkamp]

On Mon, Jan 20, 2014 at 11:28 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> On Mon, 20 Jan 2014 23:12:22 -0700, Daniel Verkamp <daniel at drv.nu> wrote:
>> On Mon, Jan 20, 2014 at 11:02 PM, Rémi Denis-Courmont <remi at remlab.net>
>> wrote:
>>> On Mon, 20 Jan 2014 23:00:03 -0700, Daniel Verkamp <daniel at drv.nu>
> wrote:
>>>> Fixes Bink video playback.
>>>
>>> The original FOURCC is an indicative value. Something is wrong if
> setting
>>> it fixes a functional bug.
>
>> I don't believe this patch should cause any problems (in fact, it
>> seems more correct from my understanding of i_original_fourcc).
>
> I never argued that the patch would cause problems. My point is that the
> patch description is wrong (or if you prefer, suspicious). By the way why
> is this only for video codecs?

Indeed, it should probably apply to the other codec types as well; I
can spin a new version of the patch with that included if the change
is acceptable.

Thanks,
-- Daniel Verkamp